refactor sub_assign DensePolynomial
#906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
Pratyush,
weikengchen and
tyshko-rostyslav
and removed request for
a team
Pratyush
reviewed
Dec 24, 2024
Pratyush
reviewed
Dec 24, 2024
| } else { | ||
| // Add the necessary number of zero coefficients. | ||
| self.coeffs.resize(other.coeffs.len(), F::zero()); | ||
| self.coeffs = other.coeffs.iter().map(|&x| -x).collect(); |
There was a problem hiding this comment.
The hope with the old way was that if self.coeffs has capacity large enough (e.g., it was the result of a previous operation that resulted in a zero), then we can avoid re-allocation via the collect.
There was a problem hiding this comment.
Oh yes you are right didn't notice that. Then there is no point to refactor this, this is already optimized, let us close :)
Co-authored-by: Pratyush Mishra <pratyush795@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer